Merge pull request #1026 from BlackDex/issue-1022

Fixes #1022 cloning with attachments
This commit is contained in:
Daniel García 2020-06-07 19:53:47 +02:00 committed by GitHub
commit 52ed8e4d75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -274,7 +274,10 @@ pub fn update_cipher_from_data(
}; };
if saved_att.cipher_uuid != cipher.uuid { if saved_att.cipher_uuid != cipher.uuid {
err!("Attachment is not owned by the cipher") // Warn and break here since cloning ciphers provides attachment data but will not be cloned.
// If we error out here it will break the whole cloning and causes empty ciphers to appear.
warn!("Attachment is not owned by the cipher");
break;
} }
saved_att.akey = Some(attachment.Key); saved_att.akey = Some(attachment.Key);